-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable autoredirect to IdP #4138
Conversation
Originally I tried to do this in the router but that required to handle this as well in the logout logic and had to take care that no components are displayed before the redirect. Handling this at the login page makes it much easier. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I noticed when trying this is, that you get redirected to the IdP login page directly after logout. I guess that's want we want - but still, wanted to point it out. @pmaier1 @LukasHirt
Adjusted tests - let's see if it needs some more love or if that is enough. I'd love to add also a test for displaying the login page when it's set but I guess this won't be possible until we have some endpoint for theming where it could be changed dynamically? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🚀
Nice, THX! Great to see this coming!
Yes, that's the expected behavior. Thanks for pointing out, though 👍 |
Fixes owncloud/product#170 |
We've added a key into the theme to enable auto-redirect to the IdP when entering ocis-web instead of displaying the login page first. The default value is set to true.