Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable autoredirect to IdP #4138

Merged
merged 6 commits into from
Oct 8, 2020
Merged

Enable autoredirect to IdP #4138

merged 6 commits into from
Oct 8, 2020

Conversation

LukasHirt
Copy link
Collaborator

We've added a key into the theme to enable auto-redirect to the IdP when entering ocis-web instead of displaying the login page first. The default value is set to true.

@LukasHirt LukasHirt requested a review from kulmann October 7, 2020 09:10
@LukasHirt LukasHirt self-assigned this Oct 7, 2020
@LukasHirt
Copy link
Collaborator Author

Originally I tried to do this in the router but that required to handle this as well in the logout logic and had to take care that no components are displayed before the redirect. Handling this at the login page makes it much easier.

@LukasHirt
Copy link
Collaborator Author

LukasHirt commented Oct 7, 2020

  • Adjust acceptance tests

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I noticed when trying this is, that you get redirected to the IdP login page directly after logout. I guess that's want we want - but still, wanted to point it out. @pmaier1 @LukasHirt

@LukasHirt
Copy link
Collaborator Author

Adjusted tests - let's see if it needs some more love or if that is enough. I'd love to add also a test for displaying the login page when it's set but I guess this won't be possible until we have some endpoint for theming where it could be changed dynamically?

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

@pmaier1
Copy link
Contributor

pmaier1 commented Oct 7, 2020

Nice, THX! Great to see this coming!

One thing I noticed when trying this is, that you get redirected to the IdP login page directly after logout. I guess that's want we want - but still, wanted to point it out. @pmaier1 @LukasHirt

Yes, that's the expected behavior. Thanks for pointing out, though 👍

@pmaier1
Copy link
Contributor

pmaier1 commented Oct 7, 2020

Fixes owncloud/product#170
Fixes owncloud/ocis#432

@LukasHirt LukasHirt merged commit 79c78ed into master Oct 8, 2020
@LukasHirt LukasHirt deleted the feature/skip-login branch October 8, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants